From 9693243e1a9310e28d20e470ab1c3233e732bcd4 Mon Sep 17 00:00:00 2001
From: C <northearts@gmail.com>
Date: Wed, 8 Feb 2023 18:13:30 +0500
Subject: [PATCH] portfinder removed, session limit move to .env config

---
 config.js                 |  2 +-
 src/modules/port_alloc.js | 33 ---------------------------------
 2 files changed, 1 insertion(+), 34 deletions(-)

diff --git a/config.js b/config.js
index 888ab55..65c33c5 100644
--- a/config.js
+++ b/config.js
@@ -7,7 +7,7 @@ module.exports = {
     database_url: process.env.DATABASE_URL,
     database_name: process.env.DATABASE_NAME,
     webrtc_port_begin: parseInt(process.env.WEBRTC_PORT_BEGIN),
-    session_limit: 100,
+    session_limit: parseInt(process.env.SESSION_LIMIT),
     log_path: "./logs/runtime.log",
     webrtc_server_path: "../pixel-streaming-webrtc/WebServers/SignallingWebServer/cirrus.js",
     app_args: {
diff --git a/src/modules/port_alloc.js b/src/modules/port_alloc.js
index 42b0c86..3d1f1da 100644
--- a/src/modules/port_alloc.js
+++ b/src/modules/port_alloc.js
@@ -1,4 +1,3 @@
-const portfinder = require('portfinder')
 const {webrtc_port_begin, session_limit} = require('../../config')
 const database = require('../database/database')
 
@@ -127,38 +126,6 @@ const free_app_port = (port) => {
     app_port_alloc.free(port)
 }
 
-// THIS MODULES DISABLED BECAUSE CAN NOT BIND PORT TO PROCESS IMMEDIATELY, CAUSE PROBLEMS IN HIGH LOAD
-
-// const get_port_in_range = async (first, last) => {
-//     //could be singleton problem
-//     portfinder.setBasePort(first)
-//     portfinder.setHighestPort(last)
-//     try {
-//         var port = await portfinder.getPortPromise()
-//         return port
-//     } catch(err) {
-//         return null
-//     }
-// }
-
-// const get_webrtc_port = async () => {
-//     var port = await get_port_in_range(webrtc_port_begin, webrtc_port_begin + session_limit - 1)
-//     return port
-// }
-
-// const get_app_port = async () => {
-//     const port_range_size_before_webrtc = webrtc_port_begin - min_available_port
-//     const port_range_after_webrtc = max_available_port - (webrtc_port_begin + session_limit)
-
-//     var port
-//     if (port_range_size_before_webrtc > port_range_after_webrtc) {
-//         port = await get_port_in_range(min_available_port, webrtc_port_begin - 1)
-//     } else {
-//         port = await get_port_in_range(webrtc_port_begin + session_limit, max_available_port)
-//     }
-//     return port
-// }
-
 module.exports = {
     get_webrtc_port,
     free_webrtc_port,